Skip to content

build: add GHES 3.14, 3.15 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gr2m merged 4 commits into from
Jan 3, 2025
Merged

build: add GHES 3.14, 3.15 #472

gr2m merged 4 commits into from
Jan 3, 2025

Conversation

@wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Nov 6, 2024

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

wolfy1339 commented Nov 6, 2024

The test failures are unrelated to this PR.
This PR unblocks the updates which contain a fix for these JSON syntax errors

@wolfy1339 wolfy1339 mentioned this pull request Jan 3, 2025
Closed
1 task
@wolfy1339 wolfy1339 linked an issue Jan 3, 2025 that may be closed by this pull request
[BUG]: JSON syntax error in version 17.0.0 #473
Closed
1 task
@wolfy1339 wolfy1339 changed the title build: add GHES 3.14 build: add GHES 3.14, 3.15 Jan 3, 2025
@wolfy1339
Copy link
Member Author

wolfy1339 commented Jan 3, 2025

@gr2m Can you merge this, ignoring the tests. That way we can get updates to fix Syntax Errors

@gr2m gr2m merged commit 741c106 into main Jan 3, 2025
4 of 5 checks passed
@gr2m gr2m deleted the wolfy1339-patch-1 branch January 3, 2025 19:21
@octokitbot
Copy link
Contributor

octokitbot commented Jan 8, 2025

🎉 This issue has been resolved in version 17.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

@kfcampbell kfcampbell Awaiting requested review from kfcampbell

Assignees

No one assigned

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: JSON syntax error in version 17.0.0

4 participants

@wolfy1339 @octokitbot @gr2m