[Breaking change] fix/update call to delete_reaction#1588
Merged
Conversation
nickfloyd
suggested changes
Jul 18, 2023
nickfloyd
left a comment
Contributor
There was a problem hiding this comment.
Hey @dimerman thank you for the contributions here! Just a few comments about the state of thing on the GitHub REST API surface. Since this is effectively a breaking change / or one where the method didn't even work I'd be inclined to even change the method name as well to more appropriately match what it does. Let me know your thoughts.
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
Contributor
Author
|
👍🏻 LGTM |
nickfloyd
previously approved these changes
Jul 18, 2023
nickfloyd
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contributions ❤️
Contributor
Author
|
@nickfloyd just fixed the specs + moved the VCR cassette 👍🏻 |
1 task
nickfloyd
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Couldn't find an open issue. Instead of opening a new one, I just fixed it.
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance