Skip to content

fix: handle bigint path parameters#547

Merged
wolfy1339 merged 1 commit into
octokit:mainfrom
jenseng:handle-bigints
Feb 18, 2026
Merged

fix: handle bigint path parameters#547
wolfy1339 merged 1 commit into
octokit:mainfrom
jenseng:handle-bigints

Conversation

@jenseng

@jenseng jenseng commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Resolves #546


Before the change?

  • Bigint placeholder values would get stripped, e.g. POST /app/hook/deliveries/{delivery_id}/attempts with delivery_id: 123n would become /app/hook/deliveries//attempts

After the change?

  • Bigint placeholder values are correctly encoded, e.g. POST /app/hook/deliveries/{delivery_id}/attempts with delivery_id: 123n becomes /app/hook/deliveries/123/attempts

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Feb 18, 2026
@wolfy1339 wolfy1339 merged commit 7f97cd9 into octokit:main Feb 18, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Feb 18, 2026
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 11.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[BUG]: bigint path parameters are removed

3 participants