Add support for selecting the libev backend (more gently)#294
Merged
Add support for selecting the libev backend (more gently)#294
Conversation
Contributor
|
Yes, that's fine. Thanks for taking care with git history & authorship! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of #269 that warns current users of
Lwt_engine.libevthat the signature will change, as per #293.The new version is available as
Lwt_engine.Versioned.libev_2. It will be released in the next Lwt release, but will replace the currentlibevin a major release.The current
libevhas a warning attached to it in the meantime:Resolves #269
cc @yallop I modified the first commit slightly:
libevtolibev'in the.mlfile,libevin terms of that, andlibevHope that is ok.