Skip to content

feat: Use s3 template configuration when set for uploads#1983

Open
pimterry wants to merge 1 commit intooclif:mainfrom
pimterry:update-templates
Open

feat: Use s3 template configuration when set for uploads#1983
pimterry wants to merge 1 commit intooclif:mainfrom
pimterry:update-templates

Conversation

@pimterry
Copy link
Contributor

This hopefully completes the work for #828, alongside oclif/plugin-update#1266. As with that PR, some thought is required on whether this will break things (publishing to the wrong URL) for anybody with Oclif v1 config left lying around.

This is a bit larger, since it refactors some of the logic into an s3Keys helper to make things a bit more manageable. There's tests included though, which means the coverage of this code goes up significantly (which is good, because it's quite difficult to test this otherwise).

I haven't contributed much to Oclif in the past so please check this carefully, I think it's all correct and should preserve the previous behaviour but it's very hard to confirm myself without representative setups to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant