feat: Use s3 template configuration when set for uploads#1983
Open
pimterry wants to merge 1 commit intooclif:mainfrom
Open
feat: Use s3 template configuration when set for uploads#1983pimterry wants to merge 1 commit intooclif:mainfrom
pimterry wants to merge 1 commit intooclif:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully completes the work for #828, alongside oclif/plugin-update#1266. As with that PR, some thought is required on whether this will break things (publishing to the wrong URL) for anybody with Oclif v1 config left lying around.
This is a bit larger, since it refactors some of the logic into an s3Keys helper to make things a bit more manageable. There's tests included though, which means the coverage of this code goes up significantly (which is good, because it's quite difficult to test this otherwise).
I haven't contributed much to Oclif in the past so please check this carefully, I think it's all correct and should preserve the previous behaviour but it's very hard to confirm myself without representative setups to test with.