fix: expanded process title checks for windows shell identification @W-21239801@#1548
Merged
jfeingold35 merged 1 commit intomainfrom Mar 2, 2026
Merged
fix: expanded process title checks for windows shell identification @W-21239801@#1548jfeingold35 merged 1 commit intomainfrom
jfeingold35 merged 1 commit intomainfrom
Conversation
iowillhoit
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1538 . Sort of. See explanation:
The issue in question is how to reliably identify whether Windows is running in Powershell. Previously, we were checking the process title for strings like
powershellandcommand prompt, which was causing problems in some situations where the process title usedpwshinstead ofpowershell.However, it turns out that there's not really any better alternative than this. I tried using
process.ppidto check the parent process, but since the CLI is run through a batch script, powershell spins up acmdprocess to execute that instead of doing it directly, so that didn't work. I looked into crawling up the chain of parent process ancestry, but that seemed like way too intensive a solution for this particular problem.So what I've done here is just add
pwshandcmdto the strings that the shell identification checks for. If the process title has either of those, it'll match.If someone else wants to implement a more intensive solution, they're welcome to do so.