[Enhancement]: delete the codes oracle related (#116)#145
Merged
LINxiansheng merged 1 commit intoJan 31, 2026
Merged
Conversation
Remove Oracle-related code from seekdb as it no longer supports Oracle compatibility mode. Changes: - Remove ob_oracle_errno, ob_oracle_errno_with_check, ob_oracle_strerror, and ob_oracle_str_user_error function declarations from ob_errno.h - Remove corresponding function definitions from ob_errno.cpp - Modify ob_errpkt_* functions to only use MySQL error handling - Update callers to use MySQL error functions instead of Oracle ones: - src/pl/ob_pl.cpp - src/sql/resolver/ddl/ob_create_view_resolver.cpp - src/observer/mysql/obmp_packet_sender.cpp - src/observer/mysql/obmp_stmt_prexecute.cpp - src/sql/engine/dml/ob_err_log_service.cpp - Remove Oracle error support from tools/ob_error Closes oceanbase#116 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Goooooooooood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ob_errno.handob_errno.cpp:ob_oracle_errnoob_oracle_errno_with_checkob_oracle_strerrorob_oracle_str_user_errorget_ob_errno_from_oracle_errnoob_errpkt_*functions to only use MySQL error handlingtools/ob_errorTest plan
Changes
src/share/ob_errno.hsrc/share/ob_errno.cppob_errpkt_*functionssrc/pl/ob_pl.cppob_oracle_strerrorwithob_strerrorsrc/sql/resolver/ddl/ob_create_view_resolver.cppob_oracle_strerrorwithob_strerrorsrc/observer/mysql/obmp_packet_sender.cppsrc/observer/mysql/obmp_stmt_prexecute.cppob_oracle_strerrorwithob_strerrorsrc/sql/engine/dml/ob_err_log_service.cpptools/ob_error/src/ob_error.cppCloses #116
🤖 Generated with Claude Code