refactor: remove shared storage code from ObServerStorageMetaService (#61)#141
Merged
LINxiansheng merged 2 commits intoJan 31, 2026
Merged
Conversation
…ceanbase#61) - Remove ObServerStorageMetaReplayer class which is shared-storage specific - Remove replayer_ and is_shared_storage_ from ObServerStorageMetaService - Flatten init/start logic to default to shared-nothing mode - Update CMakeLists.txt to exclude deleted files Addresses oceanbase#61 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
Contributor
|
This PR seems to fail the CI build |
Contributor
Author
|
Hi @WSL0809, thanks for the review! I checked the CI status for this PR, and all checks actually passed:
The PR has been successfully merged. If you're referring to a different CI failure, please let me know the details and I'll investigate further! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed
ObServerStorageMetaReplayerand related shared-storage logic fromObServerStorageMetaService.Addresses #61 as part of the AI Coding cleanup initiative (Subtask: ObServerStorageMetaReplayer cleanup).
Changes
ObServerStorageMetaReplayer(.h/.cpp) which contained logic strictly for shared storage mode.ObServerStorageMetaServiceno longer maintainsis_shared_storage_state orreplayer_instance.init(),start(), and other lifecycle methods to removeif (is_shared_storage_)branches.src/storage/CMakeLists.txtto remove the deleted source file.AI Contribution Details
This PR was developed with Claude Code assistance:
ObServerStorageMetaReplayerwas only used in shared storage paths and had no dependencies in shared-nothing mode.replayer_,is_shared_storage_).Testing
Checklist
🤖 Generated with Claude Code