fix: use pointer comparison as fallback in sort comparator error state to prevent macOS crash

obdev · wyfanxiao · LINxiansheng · ob-robot · commit 5aa611c00e8a · 2026-04-09T16:27:51.000Z
Co-authored-by: wyfanxiao &lt;wyfanxiao@163.com&gt;
Co-authored-by: LINxiansheng &lt;wangzelin19961202@gmail.com&gt;
diff --git a/src/sql/engine/sort/ob_sort_compare_vec_op.ipp b/src/sql/engine/sort/ob_sort_compare_vec_op.ipp
@@ -25,8 +25,13 @@ bool GeneralCompare<Store_Row, has_addon>::operator()(const Store_Row *l, const
   bool less = false;
   int &ret = ret_;
   if (OB_UNLIKELY(OB_SUCCESS != ret)) {
+    // Use pointer comparison as a consistent fallback to maintain strict weak ordering.
+    // Returning false for all pairs would cause introsort's right-scan loop
+    // (while !comp(pivot, *i)) to advance past array bounds, triggering abort().
+    less = l < r;
   } else if (OB_FAIL(fast_check_status())) {
     SQL_ENG_LOG(WARN, "fast check failed", K(ret));
+    less = l < r;
   } else {
     if (CompareBase::ENABLE == encode_sk_state_) {
       ObLength l_len = 0;
@@ -260,8 +265,10 @@ bool SingleColCompare<Store_Row, is_basic_cmp, is_topn_sort>::operator()(const S
   bool less = false;
   int &ret = ret_;
   if (OB_UNLIKELY(OB_SUCCESS != ret)) {
+    less = l < r;
   } else if (OB_FAIL(fast_check_status())) {
     SQL_ENG_LOG(WARN, "fast check failed", K(ret));
+    less = l < r;
   } else {
     __builtin_prefetch(l, 0 /* read */, 2 /*high temp locality*/);
     __builtin_prefetch(r, 0 /* read */, 2 /*high temp locality*/);
@@ -492,8 +499,10 @@ bool FixedCompare<Store_Row, has_addon>::operator()(const Store_Row *l, const St
   bool less = false;
   int &ret = ret_;
   if (OB_UNLIKELY(OB_SUCCESS != ret)) {
+    less = l < r;
   } else if (OB_FAIL(fast_check_status())) {
     SQL_ENG_LOG(WARN, "fast check failed", K(ret));
+    less = l < r;
   } else {
     __builtin_prefetch(l, 0 /* read */, 2 /*high temp locality*/);
     __builtin_prefetch(r, 0 /* read */, 2 /*high temp locality*/);
diff --git a/src/sql/engine/sort/ob_sort_op_impl.cpp b/src/sql/engine/sort/ob_sort_op_impl.cpp
@@ -401,12 +401,15 @@ bool ObSortOpImpl::Compare::operator()(
   bool less = false;
   int &ret = ret_;
   if (OB_UNLIKELY(OB_SUCCESS != ret)) {
-    // already fail
+    // Use pointer comparison to maintain strict weak ordering in error state,
+    // preventing Apple libc++ sort consistency check from triggering abort().
+    less = l < r;
   } else if (!is_inited() || OB_ISNULL(l) || OB_ISNULL(r)) {
     ret = !is_inited() ? OB_NOT_INIT : OB_INVALID_ARGUMENT;
     LOG_WARN("not init or invalid argument", K(ret), KP(l), KP(r));
   } else if (OB_FAIL(fast_check_status())) {
     LOG_WARN("fast check failed", K(ret));
+    less = l < r;
   } else if (enable_encode_sortkey_) {
     const ObDatum l_cell = l->cells()[0];
     const ObDatum r_cell = r->cells()[0];
