feat: Implement unit tests for VectorStore (Issue #38)#60
Merged
xxsc0529 merged 3 commits intoFeb 10, 2026
Conversation
Contributor
Author
|
Hi! This PR is now MERGEABLE with all CI checks passing. Summary:
Ready for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Changes
tests/unit_tests/test_vectorstore_standard.pyto testOceanbaseVectorStorewithout database dependencies.pyproject.tomlto resolvelangchain-coreversion conflicts and pinlangchain-tests.ObVecClientto ensure tests run in CI environments.Note on Standard Tests
The issue requested subclassing
VectorStoreUnitTestsfromlangchain_tests. However, this class does not exist in the current version (0.3.5) or latest version oflangchain-tests. Therefore, I implemented a custom test suite that follows standard unit testing patterns usingunittest.mockto isolate the database layer.