Generate binary AST on the fly in stdin input driver test#474
Merged
panglesd merged 1 commit intoocaml-ppx:mainfrom Feb 16, 2024
Merged
Generate binary AST on the fly in stdin input driver test#474panglesd merged 1 commit intoocaml-ppx:mainfrom
panglesd merged 1 commit intoocaml-ppx:mainfrom
Conversation
The point of this test is not to ensure we can read binary ASTs from a different version than the one the driver is compiled with. There is already another test for this use case. Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
pitag-ha
approved these changes
Feb 15, 2024
panglesd
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point of this test is not to ensure we can read binary ASTs from a different version than the one the driver is compiled with. There is already another test for this use case.