Disable tests on older compiler using dune#201
Merged
NathanReb merged 5 commits intoocaml-ppx:masterfrom Jan 4, 2021
Merged
Conversation
f30bbcc to
090a718
Compare
090a718 to
99907be
Compare
pitag-ha
reviewed
Dec 28, 2020
Member
pitag-ha
left a comment
There was a problem hiding this comment.
Great that we'll be able to use ocaml-ci. Thanks!
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
b888081 to
f3abfee
Compare
Collaborator
Author
|
@pitag-ha I fixed the env thing, does this look good to you? |
Member
|
It does, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes ocaml-ci for 4.07+ by disabling incompatible tests via dune. The higher the ocaml version the more tests are run.
We still need to investigate the arm32 build failure which might be related to cinaps/the cinaps stanza somehow.
For versions older than 4.07, cinaps is not available. At the moment there's no good way to handle this in ocaml-ci meaning we'll have to live without older builds for now.