Fix the indentation produced by max-indent#997
Closed
gpetiot wants to merge 8 commits intoocaml-ppx:masterfrom
gpetiot:fix-max-indent
Closed
Fix the indentation produced by max-indent#997gpetiot wants to merge 8 commits intoocaml-ppx:masterfrom gpetiot:fix-max-indent
gpetiot wants to merge 8 commits intoocaml-ppx:masterfrom
gpetiot:fix-max-indent
Conversation
gpetiot
commented
Aug 30, 2019
Collaborator
|
With match foooooooooooooooooooooo with
| ( Ppat_constraint
( ({ppat_desc= Ppat_var _; _} as p0)
, {ptyp_desc= Ptyp_poly ([], t0); _} )
, Pexp_constraint (e0, t1) )
when Poly.(t0 = t1) ->
m.value_binding mShoudn't this be like this ? match foooooooooooooooooooooo with
| ( Ppat_constraint
( ({ppat_desc= Ppat_var _; _} as p0)
, {ptyp_desc= Ptyp_poly ([], t0); _} )
, Pexp_constraint (e0, t1) )
when Poly.(t0 = t1) ->
m.value_binding m |
Collaborator
Author
|
(only half-joking) maybe we should only accept |
Collaborator
|
(the other half-joking) or we could implement it as the max indent a box can add and not on the absolute indentation across lines ? For example, with match foooooooooooooooooooooo with
| ( Ppat_constraint
( ({ppat_desc= Ppat_var _; _} as p0)
, {ptyp_desc= Ptyp_poly ([], t0); _} )
, Pexp_constraint (e0, t1) )
when Poly.(t0 = t1) ->
m.value_binding mEven if the nested tuple is indented 2 spaces more than the line before, it is indented 1 space more than the whole pattern that is indented 1 space more than the whole match |
This was referenced Nov 4, 2019
Collaborator
Author
|
Replaced by #1118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #925 (in progress)