Fix break before ending paren#801
Merged
gpetiot merged 1 commit intoocaml-ppx:masterfrom May 2, 2019
gpetiot:fix-break-before-ending-paren
Merged
Fix break before ending paren#801gpetiot merged 1 commit intoocaml-ppx:masterfrom gpetiot:fix-break-before-ending-paren
gpetiot merged 1 commit intoocaml-ppx:masterfrom
gpetiot:fix-break-before-ending-paren
Conversation
Julow
approved these changes
Apr 29, 2019
Collaborator
Julow
left a comment
There was a problem hiding this comment.
This is a big change but I agree it's better since there is no space after the opening parenthesis.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #799
Removed the call to
Location.is_single_line(#747), as a consequence we don't comply withindicate-multiline-delimitersanymore (only for these cases), but:fmt_or_k c.conf.indicate_multiline_delimiters (fits_breaks ")" " )") (fmt ")")does not work for this case)I also made the box structure closer to the one of the
functioncase.