Preserve shebang#533
Merged
gpetiot merged 5 commits intoocaml-ppx:masterfrom Jan 12, 2019
gpetiot:preserve-shebang
Merged
Conversation
jberdine
approved these changes
Jan 11, 2019
Collaborator
jberdine
left a comment
There was a problem hiding this comment.
Looks good, thanks. Minor comments only. I wonder whether we should only accept #! for implementation (and toplevel?) files, but it doesn't seem worth the complexity to check.
jberdine
approved these changes
Jan 11, 2019
hhugo
reviewed
Jan 12, 2019
| in | ||
| Warnings.parse_options false (W.to_string warnings) ; | ||
| let lexbuf = Lexing.from_channel ic in | ||
| Lexer.skip_hash_bang lexbuf ; |
Collaborator
There was a problem hiding this comment.
We should be able to know how much was skipped looking at the lexbuf. That way, we would be sure we don't drop anything.
Collaborator
Author
There was a problem hiding this comment.
It should be addressed by my last commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #523
For now, only the first line is tested, maybe something smarter could be done in the future?