Add an ocaml-version option, format punned labelled arguments when OCaml 4.14+ syntax is selected#1759
Merged
gpetiot merged 3 commits intoocaml-ppx:masterfrom Aug 3, 2021
gpetiot:fix-punned-labelled-args
Merged
Add an ocaml-version option, format punned labelled arguments when OCaml 4.14+ syntax is selected#1759gpetiot merged 3 commits intoocaml-ppx:masterfrom gpetiot:fix-punned-labelled-args
gpetiot merged 3 commits intoocaml-ppx:masterfrom
gpetiot:fix-punned-labelled-args
Conversation
nojb
reviewed
Aug 3, 2021
Contributor
nojb
left a comment
There was a problem hiding this comment.
I think the version should be 4.14+, not 4.13+.
Collaborator
Author
|
Ah indeed, I thought it would be included in the 4.13 release |
Contributor
I don't know anything about it, but I don't think it is at the moment. |
Collaborator
|
@gpetiot, what do you think about happening an issue for listing all syntaxes that need to be conditional on the ocaml version (e.g. (type a b)) |
Collaborator
Author
|
I will add a list to #633 |
jberdine
reviewed
Aug 4, 2021
| let docv = "V" in | ||
| let doc = "Version of OCaml syntax of the output." in | ||
| let default = Ocaml_version.sys_version in | ||
| let default_doc = "the currently installed OCaml version" in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #1756