Skip to content

Expose a RPC interface through a new binary ocamlformat-rpc and a new library ocamlformat-rpc-lib#1586

Merged
gpetiot merged 9 commits intoocaml-ppx:masterfrom
gpetiot:rpc
Mar 18, 2021
Merged

Expose a RPC interface through a new binary ocamlformat-rpc and a new library ocamlformat-rpc-lib#1586
gpetiot merged 9 commits intoocaml-ppx:masterfrom
gpetiot:rpc

Conversation

@gpetiot
Copy link
Copy Markdown
Collaborator

@gpetiot gpetiot commented Jan 12, 2021 •
edited
Loading

cc @emillon @voodoos @rgrinberg

The current state of this PR is:

We define a new binary ocamlformat-rpc that starts a listening loop, accepting the following commands from stdin:

  • halt
  • format-type T, the formatted type would be printed on stdout
  • invalid requests do nothing
    So far the version is not part of the protocol, but we can imagine that the client specifies it when initiating the connection with the server, and the server could return ACK/NACK or propose another version.

@rgrinberg
Copy link
Copy Markdown
Contributor

rgrinberg commented Jan 26, 2021

So far the version is not part of the protocol, but we can imagine that the client specifies it when initiating the connection with the server, and the server could return ACK/NACK or propose another version.

That seems like a good idea. Is the rpc library going to be public?

@gpetiot
Copy link
Copy Markdown
Collaborator Author

gpetiot commented Jan 26, 2021

That seems like a good idea. Is the rpc library going to be public?

Yes I guess we can release this lib as a new ocamlformat-rpc-lib package.

@gpetiot gpetiot mentioned this pull request Feb 4, 2021
Closed
@gpetiot gpetiot marked this pull request as ready for review February 10, 2021 12:29
@gpetiot gpetiot changed the title Rpc mode Expose a RPC interface through a new binary ocamlformat-rpc and a new library ocamlformat-rpc-lib Feb 10, 2021
hhugo
hhugo reviewed Feb 10, 2021
View reviewed changes
@gpetiot gpetiot requested review from Julow and emillon February 17, 2021 17:32
@gpetiot
Copy link
Copy Markdown
Collaborator Author

gpetiot commented Mar 1, 2021

This PR fulfills the needs of ocaml-lsp (@voodoos) and mdx (@NathanReb), @emillon @Julow do you have some comments on it before I release it for 0.17.1 ?

Julow
Julow approved these changes Mar 1, 2021
View reviewed changes
@gpetiot gpetiot mentioned this pull request Mar 8, 2021
Merged
@gpetiot
Copy link
Copy Markdown
Collaborator Author

gpetiot commented Mar 10, 2021 •
edited
Loading

I tried several APIs for ocamlformat-rpc-lib but I'm not satisfied with what we've got (I tried moving the client in the exposed api so that the users don't have to define it but types escape their scope everywhere, not sure I'm on the right track), if you have some ideas for improvements I'm open to it @emillon @rgrinberg
cc @voodoos

voodoos
voodoos reviewed Mar 16, 2021
View reviewed changes
This was referenced Mar 16, 2021
Merged
Merged
@voodoos voodoos mentioned this pull request Mar 16, 2021
Merged
2 tasks
@gpetiot gpetiot mentioned this pull request Mar 18, 2021
Closed
@gpetiot gpetiot merged commit 585b139 into ocaml-ppx:master Mar 18, 2021
@gpetiot gpetiot deleted the rpc branch March 18, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhugo hhugo hhugo left review comments

@Julow Julow Julow approved these changes

@emillon emillon Awaiting requested review from emillon

+1 more reviewer

@voodoos voodoos voodoos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gpetiot @rgrinberg @hhugo @Julow @voodoos @facebook-github-bot