Skip to content

Fix quoted strings with empty delimiter#1423

Merged
emillon merged 1 commit intoocaml-ppx:masterfrom
emillon:fix-quoted-strings-with-empty-delim
Jul 21, 2020
Merged

Fix quoted strings with empty delimiter#1423
emillon merged 1 commit intoocaml-ppx:masterfrom
emillon:fix-quoted-strings-with-empty-delim

Conversation

@emillon
Copy link
Copy Markdown
Collaborator

@emillon emillon commented Jul 20, 2020

As specified in the tests added in #1405, the output should be {%ext|payload|}, not {%ext |payload|}. This removes the extra space and fixes the tests on 4.11.

As specified in the tests added in ocaml-ppx#1405, the output should be
`{%ext|payload|}`, not `{%ext |payload|}`. This removes the extra space
and fixes the tests on 4.11.
@emillon emillon added this to the 4.11 support milestone Jul 20, 2020
@emillon emillon requested a review from gpetiot July 20, 2020 15:39
@emillon emillon self-assigned this Jul 20, 2020
@emillon emillon added the no changelog set this to bypass the CI check for changelog entries label Jul 20, 2020
Copy link
Copy Markdown
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@emillon emillon merged commit 0ee869c into ocaml-ppx:master Jul 21, 2020
@emillon emillon deleted the fix-quoted-strings-with-empty-delim branch July 21, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog set this to bypass the CI check for changelog entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants