Skip to content

[WIP] Fix docked collection expressions in let-bindings#1022

Closed
gpetiot wants to merge 30 commits intoocaml-ppx:masterfrom
gpetiot:docked-bindings
Closed

[WIP] Fix docked collection expressions in let-bindings#1022
gpetiot wants to merge 30 commits intoocaml-ppx:masterfrom
gpetiot:docked-bindings

Conversation

@gpetiot
Copy link
Copy Markdown
Collaborator

@gpetiot gpetiot commented Sep 17, 2019

Replaces #1008
Fix #967 also fix #1009

@gpetiot gpetiot changed the title [WIP] Fix docked collection expressions in let-bindings Fix docked collection expressions in let-bindings Sep 30, 2019
@gpetiot gpetiot requested a review from Julow September 30, 2019 08:51
@gpetiot gpetiot changed the title Fix docked collection expressions in let-bindings [WIP] Fix docked collection expressions in let-bindings Oct 1, 2019
@gpetiot
Copy link
Copy Markdown
Collaborator Author

gpetiot commented Nov 4, 2019

Rewriting most functions to return a pair Fmt.t * Fmt.t is more difficult to maintain and to get the expected output, maybe Josh is right and we should wait until we ave an intermediate ast representation for this? @Julow

@Julow
Copy link
Copy Markdown
Collaborator

Julow commented Nov 4, 2019

Yes that is becoming a mess. What we need is not an intermediate ast but a box representation that can either be manipulated or that handle docking of boxes cleanly.

@gpetiot
Copy link
Copy Markdown
Collaborator Author

gpetiot commented Nov 4, 2019

Alright, I'm closing this one in the meantime, we should restart from scratch once we have better boxes.

@gpetiot gpetiot closed this Nov 4, 2019
@gpetiot gpetiot deleted the docked-bindings branch November 4, 2019 15:40
@jberdine
Copy link
Copy Markdown
Collaborator

jberdine commented Nov 4, 2019

FTR, the 'intermediate ast' suggested in #406 isn't an ast, but a tree structure representing the (eventual) nesting of boxes. With such a structure, I think that nesting could be manipulated, and docking handled uniformly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style: break-separators=after-and-docked doesn't affect tuples Bug: break-separators=after-and-docked doesn't affect let bindings

4 participants