[WIP] Fix docked collection expressions in let-bindings#1022
Closed
gpetiot wants to merge 30 commits intoocaml-ppx:masterfrom
gpetiot:docked-bindings
Closed
[WIP] Fix docked collection expressions in let-bindings#1022gpetiot wants to merge 30 commits intoocaml-ppx:masterfrom gpetiot:docked-bindings
gpetiot wants to merge 30 commits intoocaml-ppx:masterfrom
gpetiot:docked-bindings
Conversation
Julow
reviewed
Oct 3, 2019
Collaborator
Author
|
Rewriting most functions to return a pair |
Collaborator
|
Yes that is becoming a mess. What we need is not an intermediate ast but a box representation that can either be manipulated or that handle docking of boxes cleanly. |
Collaborator
Author
|
Alright, I'm closing this one in the meantime, we should restart from scratch once we have better boxes. |
Collaborator
|
FTR, the 'intermediate ast' suggested in #406 isn't an ast, but a tree structure representing the (eventual) nesting of boxes. With such a structure, I think that nesting could be manipulated, and docking handled uniformly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1008
Fix #967 also fix #1009