-
Notifications
You must be signed in to change notification settings - Fork 217
Bug: comments in function signatures shouldn't be inside parens #966
Copy link
Copy link
Closed
Labels
Description
val select :
(* The fsevents context *)
env ->
(* Additional file descriptor to select for reading *)
?read_fdl:(fd_select list) ->
(* Additional file descriptor to select for writing *)
?write_fdl:(fd_select list) ->
(* Timeout...like Unix.select *)
timeout:float ->
(* The callback for file system events *)
(event list -> unit) ->
unit
Formatting produces:
$ ocamlformat --enable-outside-detected-project --break-separators=after-and-docked /tmp/foo.ml
val select :
(* The fsevents context *)
env ->
?read_fdl:
(* Additional file descriptor to select for reading *)
fd_select list ->
?write_fdl:
(* Additional file descriptor to select for writing *)
fd_select list ->
timeout:(* Timeout...like Unix.select *)
float ->
((* The callback for file system events *)
event list -> unit) ->
unit
The timeout comment coming after the timeout: is slightly surprising, but putting the callback comment inside the parens is more surprising. Is this intended/configurable?
Reactions are currently unavailable