timeout: add support for completion_count in timeout call#79
Closed
bikallem wants to merge 2 commits intoocaml-multicore:mainfrom
bikallem:timeout-nr
Closed
timeout: add support for completion_count in timeout call#79bikallem wants to merge 2 commits intoocaml-multicore:mainfrom bikallem:timeout-nr
bikallem wants to merge 2 commits intoocaml-multicore:mainfrom
bikallem:timeout-nr
Conversation
talex5
reviewed
Aug 30, 2022
Add more tests to demonstrate the use of `completion_count` parameter. Fix the int -> intnat in c stubs.
Contributor
|
I don't get why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying 'completion (cqe) count' when issuing
timeoutsqe to uring. By specifyingcompletion_count, timeout sqe returns0- success - when the specified number ofcompletion_countcqes complete.The parameter is an optional type with default value of
0to make it backwards compatible with earlier release.I have also made a performance improvement to
set_timespecc stub function by reducing the need to allocateint64.submit_timeoutc stub is also implemented in 2 c stubs since it has exceeded 5 parameters limit of OCaml stub functions.