Cross-platform subprocess support#499
Merged
talex5 merged 1 commit intoocaml-multicore:mainfrom May 4, 2023
Merged
Conversation
cd1a9df to
b0f3832
Compare
Closed
patricoferris
approved these changes
May 3, 2023
Collaborator
patricoferris
left a comment
There was a problem hiding this comment.
Thanks! This looks great, I like the parse_out API.
0209fd7 to
a07de9f
Compare
This also splits Eio_unix into separate modules. Co-authored-by: Thomas Leonard <talex5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on @patricoferris's #473, but rebased on top of #498 and with some changes:
Process.parse_outprovides an easy way to parse the output of a process.This also splits Eio_unix into separate modules.