lib_linux: expose log src#392
lib_linux: expose log src#392bikallem wants to merge 1 commit intoocaml-multicore:mainfrom bikallem:expose-log-src
Conversation
|
@talex5 if you don't have any objections, could we merge this as it would make debugging a bit more productive. Thanks. |
|
I wonder if we should just get rid of all the debug logging in Eio_linux. Do you find it useful for anything? |
|
I have found them to be somewhat useful, sometimes. Perhaps, leave them until 1.0? In any case, until they are completely removed, I would like to be able to control log levels to control log noise so that such debugging sessions are a bit more manageable and productive. |
|
I'd prefer to reduce the dependency cone and get rid of the Logs. When I need debug logging in the backend, I'm just putting in whatever I need. It's rarely useful to turn on the backend specific logging as part of a bigger application (which is the point of the Logs library). |
|
closing this PR since #403 supersedes it. |
Expose log source so that we can individually control log level.
Related to mirleft/ocaml-tls#461