Make sure we mint exclusive ids#368
Closed
haesbaert wants to merge 1 commit intoocaml-multicore:mainfrom
Closed
Conversation
This preserves the same id starting as 1, as fetch_and_add returns the value pre-increment. Therefore it now expresses next_id, not last_id.
Collaborator
|
Note: this will only make a difference with multiple domains, and tracing doesn't work there anyway at the moment. It might also cause a large slowdown as all domains fight over the single counter. Perhaps this will be fixed by the larger changes in #138 (which @patricoferris is investigating). |
Contributor
Author
|
Didn't know it wasn't working for multiple domains, in that way disregard this until #138 is in shape, cause it will slow things for sure. |
Merged
|
Closing as we came up with an implementation with less contention: #480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This preserves the same id starting as 1, as fetch_and_add returns the value pre-increment. Therefore it now expresses next_id, not last_id.