io-uring needs kernel version >= 5.10, not 5.11#306
Closed
nojb wants to merge 1 commit intoocaml-multicore:mainfrom
nojb:io-uring-version-test
Closed
io-uring needs kernel version >= 5.10, not 5.11#306nojb wants to merge 1 commit intoocaml-multicore:mainfrom nojb:io-uring-version-test
nojb wants to merge 1 commit intoocaml-multicore:mainfrom
nojb:io-uring-version-test
Conversation
Collaborator
|
Linux 5.11 is needed for unlink (see #289). If Windows is still on 5.10, we could bring the old fallback code back, and use the probing support (added in uring 0.4) to decide whether to use it. |
Contributor
Author
Thanks for the pointer.
Yes, WSL is still on 5.10, but 5.15 should be released soon-ish (it is currently on "prerelease"), so I'm not sure it is worth the trouble to add a fallback. But I would amend the error message for clarity: eio/lib_main/eio_main.linux.ml Line 29 in 355478d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304