Test unboxed numerics (part of unboxed-types version 2)#71
Closed
goldfirere wants to merge 18 commits intomainfrom
Closed
Test unboxed numerics (part of unboxed-types version 2)#71goldfirere wants to merge 18 commits intomainfrom
goldfirere wants to merge 18 commits intomainfrom
Conversation
Contributor
Author
|
Chatted about this with @ceastlund, who may enjoy taking a look. |
antalsz
reviewed
Mar 17, 2023
Contributor
antalsz
left a comment
There was a problem hiding this comment.
This basically looks good to me! A few comments made inline
| (Int64.add (Uint64.to_int64 x) (Uint64.to_int64 y)) in | ||
| Uint64.of_int64 (Int64.mul (Uint64.to_int64 i) (Uint64.to_int64 i)) | ||
|
|
||
| let[@inline never] g i : #int64 -> #int64 = |
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Co-authored-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
goldfirere
commented
Mar 24, 2023
| |}] | ||
|
|
||
| let f (x : #int64) = | ||
| let () = Sys.opaque_identity () in |
Contributor
Author
There was a problem hiding this comment.
To be honest, not fully sure. These got contributed by @mshinwell.
| (Int64.add (Uint64.to_int64 x) (Uint64.to_int64 y)) in | ||
| Uint64.of_int64 (Int64.mul (Uint64.to_int64 i) (Uint64.to_int64 i)) | ||
|
|
||
| let[@inline never] g i : #int64 -> #int64 = |
Contributor
Author
|
These tests appear to be well represented in the current flambda-backend. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lpw25 and I thought it might be good to write tests to accurately define the expected functionality of upcoming releases of unboxed types. There doesn't seem to be a good reason not to just check this into the repo now, but I'm happy to consider other ways of doing this.