Skip to content

Remove -absname to improve dune build errors#151

Merged
ncik-roberts merged 1 commit intoocaml-flambda:mainfrom
ncik-roberts:build-errors-with-relative-paths
Mar 17, 2023
Merged

Remove -absname to improve dune build errors#151
ncik-roberts merged 1 commit intoocaml-flambda:mainfrom
ncik-roberts:build-errors-with-relative-paths

Conversation

@ncik-roberts
Copy link
Copy Markdown
Contributor

@ncik-roberts ncik-roberts commented Mar 17, 2023

Strike -absname from dune builds. This means that (when we build the compiler) we'll get error messages like:

File "typing/typecore.ml", line 3888, characters 6-8:
Error: This pattern matches values of type unit
       but a pattern was expected which matches values of type int

instead of error messages like:

File "/usr/local/home/nroberts/ocaml/nroberts/_build/default/typing/typecore.ml", line 3888, characters 6-8:
Error: This pattern matches values of type unit
       but a pattern was expected which matches values of type int

This has better compatibility with e.g. emacs compile.

  • Old behavior: jumping to next error brought you to the _build directory
  • New behavior: jumping to next error brings you to the file you care about

@ncik-roberts ncik-roberts requested a review from mshinwell March 17, 2023 16:06
@ncik-roberts ncik-roberts mentioned this pull request Mar 17, 2023
Merged
@ncik-roberts ncik-roberts merged commit b4928ee into ocaml-flambda:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshinwell mshinwell mshinwell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncik-roberts @mshinwell