Merged
Conversation
In the parent PR we unified the `to_unpack` and `module_variable` types. This left something to be desired, as the `module_variable` terminology remained in some places. This PR removes the `to_unpack` terminology in favor of calling it `module_variable`; this makes sense with the joint removal of `type_unpacks` and leads to parallel code to `pattern_variable`.
It's natural to want to call `add_module_variables` within `type_pattern_list`; this comment clarifies why we don't do that. I found it clearer to also move the responsibility to call `add_pattern_variables` outside of `type_pattern_list`, so I make that change as well.
goldfirere
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a clone of ncik-roberts#1 --- things got in a bad state upon trying to merge that PR into the
typedtree-module-patternsbranch, and I found it most convenient to pull the commits out into a new PR against main. See that PR for discussion.This PR indeed has the same diff as the already-reviewed PR; run this to confirm: