Closed
Conversation
883fc67 to
1f39746
Compare
236c84d to
d9c0078
Compare
046c8b8 to
8aeaa3c
Compare
a8ac51d to
8c7359e
Compare
Closed
Contributor
Author
|
This is closed in favour of #138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the previous PR (#33), and tries to add support for the uniqueness extension.
uniquenessaxis containsunique<shared. Thelinearityaxis containsmany<once. To accomodate the new axes, some refactoring and renaming are done. More of that is due but I think it's better to merge this ASAP instead of rebasing weekily.uniqueare actually so, we adduniqueness_analysis.mlthat checks the usage of each values (In particular,Texp_identandTexp_field).The extension still has many issues, our minimal goal in this PR is that existing code will translate to the same machine code when the
uniqueextension is disabled. Existing code might be rejected by type checker due to some bugs we introduced, but that's less scary. To achieve this minimal goal, the following is needed:localityaxis in thealloc_modein thetypedtreegenerated bytypecore.ml.translcore.ml, add assertions that the two new lambda primitives (that overwrite fields in blocks),PreuseblockandPreusefloatblockare generated only whenuniqueextension enabled.lambda.ml, we adduniquenesstoalloc_mode.uniquenesscould be eitheralloc_uniqueoralloc_shared. The former is redirected to the latter when the extension is disabled. Further inspection is needed to ensure thattranslcore.mlretains old behaviour whenuniquenessisalloc_shared.