Fix demoting apply_cont in switch#464
Merged
mshinwell merged 5 commits intoocaml-flambda:flambda2.0-stablefrom Jun 9, 2021
Merged
Fix demoting apply_cont in switch#464mshinwell merged 5 commits intoocaml-flambda:flambda2.0-stablefrom
mshinwell merged 5 commits intoocaml-flambda:flambda2.0-stablefrom
Conversation
|
In order for the new test to actually be run by CI, you need to add a line with the folder name (in this case |
Author
|
Thanks I would have missed that. I took the opportunity to also add another missing test dir |
|
This looks good and I'm going to merge it now. However I think some changes might be needed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes to exception continuations of #451 have not been propagated to the apply_cont in switches. This fixes some problems related to that. I do not know if this misses things in
Rebuild_expr. @mshinwell you should look carefully there to see if any changes to this is required there.