Fix runtime/dune (remove .depend hack)#460
Merged
mshinwell merged 1 commit intoocaml-flambda:flambda2.0-stablefrom May 26, 2021
Merged
Fix runtime/dune (remove .depend hack)#460mshinwell merged 1 commit intoocaml-flambda:flambda2.0-stablefrom
mshinwell merged 1 commit intoocaml-flambda:flambda2.0-stablefrom
Conversation
mshinwell
approved these changes
May 26, 2021
|
Looks plausible, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping that this will remove the errors we get from time to time on the dune CI while building the runtime. I'm not a dune expert though, so I don't know if my solution is reasonable or likely to open the gates of hell. Reviews welcome.