Skip to content

Remove no longer needed template file.#89

Merged
Leonidas-from-XIV merged 1 commit intoocaml-community:masterfrom
bschommer:master
Jul 13, 2020
Merged

Remove no longer needed template file.#89
Leonidas-from-XIV merged 1 commit intoocaml-community:masterfrom
bschommer:master

Conversation

@bschommer
Copy link
Contributor

@bschommer bschommer commented Nov 22, 2019

I stumbled upon some problems with the latest version due to this file. With this file the dune-package generated was wrong and looked like this:

(lang dune 2.0)
(use_meta)
(version 17dc47d)

And compiling ppx_yojson_conv failed with the error message :

File "<lib>/yojson/dune-package", line 3, characters 1-8:
3 | (version 17dc47d)
     ^^^^^^^
Error: Unknown field version

@bschommer bschommer requested a review from NathanReb as a code owner November 22, 2019 14:20
Leonidas-from-XIV
Leonidas-from-XIV approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to keep a generated file from jbuilder days, so I'm merging this. Thanks for your contribution!

@Leonidas-from-XIV Leonidas-from-XIV merged commit c0f127a into ocaml-community:master Jul 13, 2020
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

@NathanReb NathanReb Awaiting requested review from NathanReb NathanReb is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bschommer @Leonidas-from-XIV