Revive benchmark#76
Merged
NathanReb merged 2 commits intoocaml-community:masterfrom Jan 29, 2019
Leonidas-from-XIV:revive-benchmark
Merged
Revive benchmark#76NathanReb merged 2 commits intoocaml-community:masterfrom Leonidas-from-XIV:revive-benchmark
NathanReb merged 2 commits intoocaml-community:masterfrom
Leonidas-from-XIV:revive-benchmark
Conversation
Member
Author
|
For the record, current values on the machine I'm developing on: |
NathanReb
approved these changes
Jan 29, 2019
Collaborator
NathanReb
left a comment
There was a problem hiding this comment.
Thank you very much, this is a welcome change!
As you already said this is meant for developers so indeed using an external benchmark library isn't an issue at all here.
With time it might be interesting to add various type of input. Having a way to generate them so that we don't have to commit various and potentially large json files to the repo would probably be the way to go.
That's already great as it is and at least we have something to work with now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are not benchmarking against JSON Wheel anymore I took the liberty to remove the dependency and just port the previous benchmark into
Core_benchwhich is very good at reporting performance numbers. Since this is not part of what people will need to use yojson or even run its tests I thought I'd prefer to just use an existing mature benchmark solution instead of rolling my own.Maybe some more demanding benchmark data would be nice, and some more operations to test but for now I'll just await your input.