Skip to content

Update benchmarks and domainslib to support ocaml 4.14.0+domains (ocaml 5.0)#261

Merged
shakthimaan merged 26 commits intoocaml-bench:masterfrom
shubhamkumar13:update-benchmarks-for-ocaml-5.0
Nov 23, 2021
Merged

Update benchmarks and domainslib to support ocaml 4.14.0+domains (ocaml 5.0)#261
shakthimaan merged 26 commits intoocaml-bench:masterfrom
shubhamkumar13:update-benchmarks-for-ocaml-5.0

Conversation

@shubhamkumar13
Copy link
Copy Markdown
Contributor

@shubhamkumar13 shubhamkumar13 commented Nov 9, 2021

This PR is the first step in adding ocaml 5.0 support for the benchmarks in sandmark.

The PR adds domainslib.0.3.2 and updates the benchmarks supporting the updated api for domainslib

@shakthimaan
Copy link
Copy Markdown
Contributor

shakthimaan commented Nov 10, 2021 

# OCaml version mismatch: 5.00.0, expected 4.14.0

The version number mismatch is causing the 4.14.0+trunk build to fail. The following issue is related: ocaml-multicore/ocaml-multicore#709.

@kayceesrk
Copy link
Copy Markdown
Contributor

kayceesrk commented Nov 11, 2021

Looks like upstream has changed the version number to 5.00.0: https://github.com/ocaml/ocaml/blob/trunk/VERSION#L1. So 4.14.0+trunk should be 5.00.0+trunk.

@kayceesrk
Copy link
Copy Markdown
Contributor

kayceesrk commented Nov 13, 2021

Ping @shubhamkumar13.

@shubhamkumar13 shubhamkumar13 mentioned this pull request Nov 15, 2021
Open
@shubhamkumar13
Copy link
Copy Markdown
Contributor Author

shubhamkumar13 commented Nov 18, 2021 •
edited
Loading

I've added an issue tracing irmin benchmarks failing on ocaml.5.00.0+trunk which would be fixed when the trunk is frozen (which would be easier for generating ppxlib version supporting trunk).

I think it's best to merge this before and then #257 can be merged (since there are changes to drome.yml file where I've updated the trunk from 4.14.0+trunk to 5.00.0+trunk)

@shubhamkumar13
Copy link
Copy Markdown
Contributor Author

shubhamkumar13 commented Nov 18, 2021

This PR also updates drone.yml file to 5.00.
This is in addition to the adding the updated domainslib and making benchmarks compatible to 5.00

shakthimaan
shakthimaan reviewed Nov 18, 2021
View reviewed changes
@shubhamkumar13
add ppxlib and it's dependencies in case statement to ensure that oca…
418ccdc 
…ml-migrate-parsetree build is not attempted in OCaml.5.00.0
shakthimaan
shakthimaan reviewed Nov 22, 2021
View reviewed changes
@shakthimaan shakthimaan merged commit aff885d into ocaml-bench:master Nov 23, 2021
@shubhamkumar13 shubhamkumar13 mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctk21 ctk21 Awaiting requested review from ctk21

1 more reviewer

@shakthimaan shakthimaan shakthimaan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubhamkumar13 @shakthimaan @kayceesrk