OCaml 5.0: define SITELIB variable when installing 5.0.0+trunk#21468
Closed
Octachron wants to merge 2 commits intoocaml:masterfrom
Closed
OCaml 5.0: define SITELIB variable when installing 5.0.0+trunk#21468Octachron wants to merge 2 commits intoocaml:masterfrom
Octachron wants to merge 2 commits intoocaml:masterfrom
Conversation
Member
Author
|
Superseded by the removal of SITELIB in the final version of the compiler META files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is considering the option to install its own META files directly in ocaml/ocaml#11007 .
To keep a maximal compatibility with ocamlfind, we are proposing to add a SITELIB configuration variable to the compiler.
The compiler will then install the META files for the compiler distributed libraries according to the ocamlfind's sitelib convention.
This draft PR updates the package for OCaml 5.0.0+trunk in order to define this variable in its first commit.
In the second commit, I propose to use the new compiler-distributed META files to remove the ocamlfind dependency of the
base-bytescompatibility packages (since the META file will be directly distributed by the compiler itself).