Merged
Conversation
CHANGES: - Fix missing -linkall flag when linking library dune-sites.plugin ( ocaml/dune#4348, @Kakadu, @bobot, reported by @Kakadu) - No longer reference deprecated Toploop functions when using dune files in OCaml syntax. (ocaml/dune#4834, fixes ocaml/dune#4830, @nojb) - Use the stag format API to be compatible with OCaml 5.0 (ocaml/dune#5351, @emillon). - Fix post-processing of dune-package (fix ocaml/dune#4389, @strub)
Member
|
Looks good, thanks! Though, according to the changelog, it looks like |
Contributor
|
That's right there is a one liner fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast, portable, and opinionated build system
CHANGES:
Fix missing -linkall flag when linking library dune-sites.plugin
( Add a test about dune-sites where plugin links extra libary. dune#4348, @Kakadu, @bobot, reported by @Kakadu)
No longer reference deprecated Toploop functions when using dune files in
OCaml syntax. (Use Toploop.add_directive dune#4834, fixes deprecated alert when using ocaml syntax in dune files with ocaml 4.13~alpha2 dune#4830, @nojb)
Use the stag format API to be compatible with OCaml 5.0 ([2.9] Compatibility with OCaml 5.0 dune#5351, @emillon).
Fix post-processing of dune-package (fix Failed to parse file, not adding version and locations information dune#4389, @strub)