Skip to content

[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.5.4)#16849

Merged
mseri merged 1 commit intoocaml:masterfrom
mseri:release-cohttp-2.5.4
Jul 23, 2020
Merged

[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.5.4)#16849
mseri merged 1 commit intoocaml:masterfrom
mseri:release-cohttp-2.5.4

Conversation

@mseri
Copy link
Copy Markdown
Member

@mseri mseri commented Jul 21, 2020

CoHTTP implementation for the Js_of_ocaml JavaScript compiler

CHANGES:

@camelus
Copy link
Copy Markdown
Contributor

camelus commented Jul 21, 2020

Commit: aa72418

A pull request by opam-seasoned @mseri.

☀️ All lint checks passed aa72418
  • These packages passed lint tests: cohttp-async.2.5.4, cohttp-lwt-jsoo.2.5.4, cohttp-lwt-unix.2.5.4, cohttp-lwt.2.5.4, cohttp-mirage.2.5.4, cohttp-top.2.5.4, cohttp.2.5.4

☀️ Installability check (+7)
  • new installable packages (7): cohttp.2.5.4 cohttp-async.2.5.4 cohttp-lwt.2.5.4 cohttp-lwt-jsoo.2.5.4 cohttp-lwt-unix.2.5.4 cohttp-mirage.2.5.4 cohttp-top.2.5.4

@avsm
Copy link
Copy Markdown
Member

avsm commented Jul 21, 2020

Looks like a failure in the core package on some OCaml versions

# File "cohttp/src/header.ml", line 98, characters 2-18:
# Error: Unbound value StringMap.update

@mseri
Copy link
Copy Markdown
Member Author

mseri commented Jul 21, 2020

Argh, well spotted @avsm. Map.update has been introduced in ocaml 4.06.0. I can reimplement it in cohttp, or we could add a lower bound on ocaml 4.06. What would you prefer?

@mseri
Copy link
Copy Markdown
Member Author

mseri commented Jul 22, 2020

I will update the release once the PR to add support for older compilers (mirage/ocaml-cohttp#703) is merged

…ohttp-top, cohttp-async and cohttp-mirage (2.5.4)

CHANGES:

- cohttp: a change in mirage/ocaml-cohttp#694 modified the semantics of Header.replace.
  The semantics change is reverted, and a new Header.update function
  is introduced, following the semantics of Map.update. (mirage/ocaml-cohttp#702 @mseri)
- cohttp: reimplement update to support compilers that are older than
  OCaml 4.06 (mirage/ocaml-cohttp#703 @mseri)
@mseri mseri force-pushed the release-cohttp-2.5.4 branch from 1c3707c to aa72418 Compare July 22, 2020 08:53
@mseri mseri merged commit 6d787a6 into ocaml:master Jul 23, 2020
@mseri mseri deleted the release-cohttp-2.5.4 branch July 23, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants