Merged
Conversation
Contributor
☀️ All lint checks passed 6c853e7
☀️ Installability check (10192 → 10193)
|
34777bb to
cd59a09
Compare
Member
Author
|
@avsm or @kit-ty-kate is it possible to restart the build? |
Member
|
anybody can do it for ci/datakit. You can just click on "rebuild" |
Member
|
though in this case rebuilding does nothing as the archive does not exist |
CHANGES: - Fix merlin handling of private module visibility (ocaml/dune#1653 @bobot) - skip directories when looking up programs in the PATH (ocaml/dune#1628, fixes ocaml/dune#1616, @diml) - Fix preprocessing for libraries with `(include_subdirs ..)` (ocaml/dune#1624, fix ocaml/dune#1626, @nojb, @rgrinberg) - Do not generate targets for archive that don't match the `modes` field. (ocaml/dune#1632, fix ocaml/dune#1617, @rgrinberg) - When executing actions, open files lazily and close them as soon as possible in order to reduce the maximum number of file descriptors opened by Dune (ocaml/dune#1635, ocaml/dune#1643, fixes ocaml/dune#1633, @jonludlam, @rgrinberg, @diml) - Do not generate targets for archive that don't match the `modes` field. (ocaml/dune#1632, fix ocaml/dune#1617, @rgrinberg) - Get the correct environment node for multi project workspaces (ocaml/dune#1648, @rgrinberg) - Fix an issue causing menhir generated parsers to fail to build in some cases. The fix is to systematically use `-short-paths` when calling `ocamlc -i` (ocaml/dune#1743, fix ocaml/dune#1504, @diml)
cd59a09 to
6c853e7
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES:
Fix merlin handling of private module visibility (Fix merlin handling of private module dune#1653 @bobot)
skip directories when looking up programs in the PATH (Skip directories when looking up programs in the PATH dune#1628, fixes
Dune attempts to run non-executable in $PATH, but only under certain circumstances dune#1616, @diml)
Fix preprocessing for libraries with
(include_subdirs ..)((preprocess (action ...)) cannot be used with (include_subdirs unqualified) dune#1624, fix Add test for using (include_subdirs unqualified) + (preprocess (action ...)) dune#1626,@nojb, @rgrinberg)
Do not generate targets for archive that don't match the
modesfield.(Do not generate extra targets for bytecode only libs dune#1632, fix building @all includes .cmx/.o targets dune#1617, @rgrinberg)
When executing actions, open files lazily and close them as soon as
possible in order to reduce the maximum number of file descriptors
opened by Dune (Delay opening redirected files until execing cmd dune#1635, Revert #1635 + fix for #1633 dune#1643, fixes Build failure on macOS with Dune master dune#1633, @jonludlam, @rgrinberg, @diml)
Do not generate targets for archive that don't match the
modesfield.(Do not generate extra targets for bytecode only libs dune#1632, fix building @all includes .cmx/.o targets dune#1617, @rgrinberg)
Get the correct environment node for multi project workspaces (Fix getting node for directories dune#1648,
@rgrinberg)