Skip to content

opam update: Skip removing a version-equivalent package on rename.#6774

Merged
rjbou merged 2 commits intoocaml:masterfrom
arozovyk:opam_load_version_compare
Nov 7, 2025
Merged

opam update: Skip removing a version-equivalent package on rename.#6774
rjbou merged 2 commits intoocaml:masterfrom
arozovyk:opam_load_version_compare

Conversation

@arozovyk
Copy link
Copy Markdown
Collaborator

@arozovyk arozovyk commented Nov 4, 2025

Fixes #6754
Backported to 2.5 by #6784

@arozovyk arozovyk self-assigned this Nov 4, 2025
@arozovyk arozovyk added this to the 2.5.0~alpha2 milestone Nov 4, 2025
@kit-ty-kate
Copy link
Copy Markdown
Member

Could you split into 2 commits (one for the test and one for the fix) so that we are able to see the difference?

@arozovyk arozovyk force-pushed the opam_load_version_compare branch 2 times, most recently from 9a791ca to 36f27bf Compare November 4, 2025 15:26
@arozovyk
Copy link
Copy Markdown
Collaborator Author

arozovyk commented Nov 4, 2025

@kit-ty-kate

Locally i had a local git repository instead of a local directory. I believe that instead of having a separate DELETE step, it went through Patch.Rename_only. Could you add a test showing that in your PR for completeness?

It does hit Patch.Rename_only in case of the git repository, but there's no bug on master as you can see.

@arozovyk arozovyk force-pushed the opam_load_version_compare branch from 9cbf939 to aeccf5d Compare November 7, 2025 14:01
@kit-ty-kate kit-ty-kate requested a review from rjbou November 7, 2025 14:54
@rjbou rjbou merged commit 6c6bc9b into ocaml:master Nov 7, 2025
46 checks passed
@rjbou rjbou changed the title Skip removing a version-equivalent package on rename. opam update: Skip removing a version-equivalent package on rename. Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntaxic differences in version numbers are kept accross updates

3 participants