Clean variables before calling make on different projects to avoid clashes#6769
Merged
rjbou merged 1 commit intoocaml:masterfrom Nov 7, 2025
Merged
Clean variables before calling make on different projects to avoid clashes#6769rjbou merged 1 commit intoocaml:masterfrom
rjbou merged 1 commit intoocaml:masterfrom
Conversation
This was referenced Nov 3, 2025
Merged
…ashes This fixes the compilation of the OCaml compiler on Windows during the release process
003b6f6 to
712e9d6
Compare
rjbou
approved these changes
Nov 7, 2025
MisterDA
reviewed
Nov 8, 2025
| git clone $(GIT_URL) -b $(TAG) "$(OUTDIR)/opam-full-$(VERSION)" | ||
| $(MAKE) -C "$(OUTDIR)/opam-full-$(VERSION)" OCAML=$(call pathsearch,ocaml) download-ext | ||
| unset MAKEFLAGS MAKEOVERRIDES && \ | ||
| $(MAKE) -C "$(OUTDIR)/opam-full-$(VERSION)" OCAML=$(call pathsearch,ocaml) download-ext |
Contributor
There was a problem hiding this comment.
Is this missing -j$(JOBS)?
Member
Author
There was a problem hiding this comment.
the release script isn't called with -j so it wouldn't matter and i'd rather not download things in parallel anyway to avoid network failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compilation of the OCaml compiler on Windows during the release process
Backported to 2.5 in #6770