Skip to content

GHA: Add OCaml 5.4 to the test matrix#6732

Merged
rjbou merged 2 commits intoocaml:masterfrom
kit-ty-kate:gha-5.4
Nov 6, 2025
Merged

GHA: Add OCaml 5.4 to the test matrix#6732
rjbou merged 2 commits intoocaml:masterfrom
kit-ty-kate:gha-5.4

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate commented Oct 9, 2025 •
edited
Loading

The second "temporary" commit is necessary to have ocamlfind and lwt working, per the comments below.
Once merged i'll open a separate PR to revert it for whenever these two projects have been fixed upstream

@kit-ty-kate kit-ty-kate added this to the 2.5.0~alpha1 milestone Oct 9, 2025
@kit-ty-kate kit-ty-kate force-pushed the gha-5.4 branch 3 times, most recently from 21efaee to 5d0c341 Compare October 9, 2025 23:55
@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Oct 10, 2025

@dra27 do you have any idea where the errors are coming from?

#=== ERROR while compiling ocamlfind.1.9.8 ====================================#
# context              2.5.0~alpha1~dev | cygwin/x86_64 | ocaml-system.5.4.0 | git+https://github.com/ocaml/opam-repository.git#38a1469dbbc69c770e534e26f79c97256a442b71
# path                 ~/.opam/default/.opam-switch/build/ocamlfind.1.9.8
# command              /usr/bin/make all
# exit-code            2
# env-file             ~/.opam/log/ocamlfind-629-efe79b.env
# output-file          ~/.opam/log/ocamlfind-629-efe79b.out
### output ###
# [...]
# make[2]: Entering directory '/home/runneradmin/.opam/default/.opam-switch/build/ocamlfind.1.9.8'
# USE_CYGPATH="0"; \
# export USE_CYGPATH; \
# cat findlib.conf.in | \
#      tools/patch '@SITELIB@' '/home/runneradmin/.opam/default/lib' | \
# 		 tools/patch '@FINDLIB_PATH@' '/cygdrive/d/Cache/ocaml-local/lib/ocaml;/home/runneradmin/.opam/default/lib' -p >findlib.conf
# sed: -e expression #1, char 58: unknown option to `s'
# make[2]: *** [Makefile:55: findlib-template] Error 1
# make[2]: Leaving directory '/home/runneradmin/.opam/default/.opam-switch/build/ocamlfind.1.9.8'
# make[1]: *** [Makefile:82: findlib.conf] Error 2
# make[1]: Leaving directory '/home/runneradmin/.opam/default/.opam-switch/build/ocamlfind.1.9.8'
# make: *** [Makefile:15: all] Error 2

@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Oct 10, 2025 •
edited
Loading

The rest of the errors are tracked in the lwt bugtracker:

@dra27
Copy link
Copy Markdown
Member

dra27 commented Oct 10, 2025

I think we have never tested findlib 1.9.8 on Cygwin with OCaml 5.x? There's an escaping issue in https://github.com/ocaml/ocamlfind/blob/findlib-1.9.8/tools/patch - when building findlib with Cygwin itself, USE_CYGPATH=0 IIRC. I think it's a bug in findlib, therefore (I'm just building locally)

@dra27 dra27 mentioned this pull request Oct 18, 2025
Open
@kit-ty-kate kit-ty-kate force-pushed the gha-5.4 branch 3 times, most recently from dc1c9f6 to 5953047 Compare November 3, 2025 17:54
@kit-ty-kate kit-ty-kate requested a review from rjbou November 4, 2025 17:27
@kit-ty-kate kit-ty-kate mentioned this pull request Nov 4, 2025
Merged
@kit-ty-kate kit-ty-kate modified the milestones: 2.5.0~alpha2, 2.6.0~alpha1 Nov 4, 2025
@rjbou rjbou merged commit 558fedf into ocaml:master Nov 6, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjbou rjbou rjbou approved these changes

Assignees

@dra27 dra27

Labels

AREA: TEST

Projects

None yet

Milestone

2.6.0~alpha1

Development

Successfully merging this pull request may close these issues.

3 participants

@kit-ty-kate @dra27 @rjbou