Skip to content

Simplify the src_ext/update-sources.sh script#6701

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate:simplify-update-sources-bash
Sep 22, 2025
Merged

Simplify the src_ext/update-sources.sh script#6701
kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate:simplify-update-sources-bash

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

Required during #6700 to update menhir as the URL couldn't be parsed.
While trying to fix that i found the script too complex so i chose to simplify it instead.

@kit-ty-kate kit-ty-kate added this to the 2.5.0~alpha1 milestone Sep 18, 2025
@kit-ty-kate kit-ty-kate requested a review from rjbou September 18, 2025 12:02
@kit-ty-kate kit-ty-kate requested review from dra27 and removed request for rjbou September 18, 2025 12:02
@dra27
Copy link
Copy Markdown
Member

dra27 commented Sep 22, 2025

Go for it - it's only intended as a utility, and if the extra error checking isn't being helpful, better to remove it!

@kit-ty-kate kit-ty-kate merged commit e464f94 into ocaml:master Sep 22, 2025
46 checks passed
@kit-ty-kate kit-ty-kate deleted the simplify-update-sources-bash branch September 22, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants