Pretty printing of some error for opam source & build actions#6696
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Sep 19, 2025
Merged
Pretty printing of some error for opam source & build actions#6696kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate merged 2 commits intoocaml:masterfrom
Conversation
2 tasks
d166d05 to
02416cb
Compare
kit-ty-kate
approved these changes
Sep 17, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
lgtm. I've added the missing changelog item as this changes the behaviour of opam source from a fatal error due to an uncaught exception, to a warning.
I'm not too convinced this should be a warning (i would rather expect an error) but since the other errors were a warning too i think it's fine and it can be changed later if needed. This is orthogonal to the PR.
Collaborator
Author
|
On windows - - ${BASEDIR}/OPAM/repo/default/packages/escape-absolute/escape-absolute.1/files//etc/passwdd
+ - ${BASEDIR}/OPAM/repo/default/packages/escape-absolute/escape-absolute.1/files/etc/passwddThe error came from |
02416cb to
da06f1d
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queued on