Merged
Conversation
d747956 to
7c3c121
Compare
kit-ty-kate
reviewed
Sep 5, 2025
7c3c121 to
d3b009e
Compare
Collaborator
Author
|
Updated. I've added a commit to indent the file, it was very messy (seems my fault, wrong switch in the time i guess). |
rjbou
commented
Sep 11, 2025
| Printf.sprintf {|C:\Windows\system32\%s.exe|} cmd; | ||
| Printf.sprintf {|C:\Windows\system32\%s|} cmd; | ||
| Printf.sprintf {|C:\Windows\system 32\%s.exe|} cmd; | ||
| Printf.sprintf {|C:\Windows\system 32\%s|} cmd; |
Collaborator
Author
There was a problem hiding this comment.
what are the other paths that we can add ?
kit-ty-kate
reviewed
Sep 11, 2025
kit-ty-kate
approved these changes
Sep 11, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
Aside from the one minor indentation related comment, lgtm
d3b009e to
7a2ffe2
Compare
…een sandboxed and non sandboxed commands (with '-vv')
7a2ffe2 to
d96ba24
Compare
Collaborator
Author
|
Updated the PR. I've added a test & fix to homogeneise output between sandboxed & non sandboxed commands verbose mode to fix what we saw on windows run Processing 2/3: [build: true]
-+ true (CWD=${BASEDIR}/OPAM/global-variable/.opam-switch/build/build.1)
++ true (CWD=${BASEDIR}/OPAM/global-variable/.opam-switch/build/build.1)
-> compiled build.1 |
kit-ty-kate
approved these changes
Sep 23, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to permit no space at the end