Add AppArmor support to the install script#6647
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Oct 16, 2025
Merged
Conversation
Member
|
Gentle ping! |
rjbou
approved these changes
Oct 16, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
Light approval. This PR was tested successfully by users that had the issue, and i tested it locally successfully too. But I'm not an apparmor expert, it's difficult for me to validate if it is the good level of permission (though it is mimicking official opam one).
Let's merge it and use the 2.5 alpha to supervise and have feedback on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5968
Was tested with success in #5968 (comment)
For reference, here is the upstream apparmor profile for opam (when located at
/usr/bin/opam): https://gitlab.com/apparmor/apparmor/-/blob/65e6620014759ac1b671bf982b8c67eac2e789fe/profiles/apparmor.d/opam