Fix pinned depends being ignored on simulated pins#6611
Merged
kit-ty-kate merged 4 commits intoocaml:masterfrom Oct 7, 2025
Merged
Fix pinned depends being ignored on simulated pins#6611kit-ty-kate merged 4 commits intoocaml:masterfrom
kit-ty-kate merged 4 commits intoocaml:masterfrom
Conversation
25b3372 to
3ccef19
Compare
3ccef19 to
71b33c8
Compare
71b33c8 to
3d7cb77
Compare
…sence of pin-depends
3d7cb77 to
2c44cbe
Compare
2c44cbe to
27d423c
Compare
rjbou
approved these changes
Oct 7, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
lgtm!
I've used your tests added in autopin to write pin-depends and pin-depends-ignore pin-depends (as the name doesn't let it know 🙃) specific tests. It's in separate commits (and no changelog, i've also added proceed-actions autoanswer), feel free to squash/reorder commits if it's ok for you.
About the last commit, if you can add also some textual information, we don't always have issue numbers in mind :)
27d423c to
7659ee3
Compare
rjbou
reviewed
Oct 7, 2025
7659ee3 to
e6ec274
Compare
e6ec274 to
5c32376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6610
Backported to 2.4 in #6612
Queued on: