Bash support: write to the .bashrc instead of the .profile file#6603
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Oct 16, 2025
Merged
Bash support: write to the .bashrc instead of the .profile file#6603kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate merged 1 commit intoocaml:masterfrom
Conversation
123d318 to
670d6a9
Compare
rjbou
approved these changes
Oct 16, 2025
On some systems, the .profile file already sources .bashrc so telling the user to source .profile in their .bashrc creates a loop. Furthermore, given that on some systems the .bashrc is already sourced in the .profile, it makes it more like for users to copy the opam incantation in their .bashrc but forget to remove it from the .profile, leading to a doubling of some environment variables and a loss of track of some of them by opam env
670d6a9 to
63a5d48
Compare
|
Thank you! This fix goes out of its way to produce a good setup and error messages — I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some systems, the .profile file already sources .bashrc so telling the user to source .profile in their .bashrc creates a loop. Furthermore, given that on some systems the .bashrc is already sourced in the .profile, it makes it more like for users to copy the opam incantation in their .bashrc but forget to remove it from the .profile, leading to a doubling of some environment variables and a loss of track of some of them by
opam env(aka. #6455)Fixes #5819
Fixes #4201
Fixes #3990