Fix opam pin list when the internal source directory of the pinned package doesn't exist#6597
Draft
kit-ty-kate wants to merge 2 commits intoocaml:masterfrom
Draft
Fix opam pin list when the internal source directory of the pinned package doesn't exist#6597kit-ty-kate wants to merge 2 commits intoocaml:masterfrom
opam pin list when the internal source directory of the pinned package doesn't exist#6597kit-ty-kate wants to merge 2 commits intoocaml:masterfrom
Conversation
54fa2b4 to
04c680a
Compare
04c680a to
af76a61
Compare
rjbou
reviewed
Jul 15, 2025
tests/reftests/pin.test
Outdated
| pinned-pkg is now pinned to git+file://${BASEDIR}/no-source-dir#master (version dev) | ||
| ### rm -r OPAM/no-source-dir/.opam-switch/sources/pinned-pkg | ||
| ### opam pin | ||
| pinned-pkg.dev (uninstalled) git git+file://${BASEDIR}/no-source-dir#master (at error while fetching current revision) |
Collaborator
There was a problem hiding this comment.
Suggested change
| pinned-pkg.dev (uninstalled) git git+file://${BASEDIR}/no-source-dir#master (at error while fetching current revision) | |
| pinned-pkg.dev (uninstalled) git git+file://${BASEDIR}/no-source-dir#master (error while fetching current revision) |
Or even more concise
Suggested change
| pinned-pkg.dev (uninstalled) git git+file://${BASEDIR}/no-source-dir#master (at error while fetching current revision) | |
| pinned-pkg.dev (uninstalled) git git+file://${BASEDIR}/no-source-dir#master (no revision found) |
Collaborator
|
On the idea, lgtm! |
opam pin list when the source of the pinned package doesn't exist
opam pin list when the source of the pinned package doesn't existopam pin list when the internal source directory of the pinned package doesn't exist
af76a61 to
aa6f813
Compare
rjbou
approved these changes
Jul 15, 2025
Member
Author
|
TODO:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #6274
Backported to the 2.4 branch in #6598