Update Windows bootstrap dependencies#6592
Conversation
I think it's ok as i don't think this should be part of the upcoming opam 2.4 which was branched already and whose release candidate has already been released. This PR will do fine for opam 2.5 though i think |
a24ae0f to
0fec3f5
Compare
0fec3f5 to
5543e9b
Compare
|
Vendoring mingw-w64 13.0.0's winpthreads doesn't work with OCaml 5.3.0 because the source changed significantly. In particular the file that OCaml's configure script tried to lookup to detect whether winpthreads is here is now missing in that version. I've removed that commit from the PR and it should now be good to go |
|
Thanks! |
|
Turns out all of these dependencies simply do not work with OCaml 4.14 so i have to revert this PR. I'm not too sure why it works in CI but not during the release process though. We can revisit it once we upgrade to OCaml 5 (hopefully 5.5 or whenever the GC pacing issue is taken care of) |
Sorry, but that's simply wrong. The dependencies work well with OCaml 4.14. It's the bootstrap process that passes opam's version to FlexDLL instead of FlexDLL's version. |
I've noticed that some of the dependencies could be updated. The updates could help when bootstrapping or building opam under Windows.
I'm a bit dissatisfied to "dump" this PR on the maintainers this late in the release process, without being able to check if the CI follows through, but I don't have much more time available.