Skip to content

Update Windows bootstrap dependencies#6592

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
MisterDA:update-windows-deps
Oct 14, 2025
Merged

Update Windows bootstrap dependencies#6592
kit-ty-kate merged 2 commits intoocaml:masterfrom
MisterDA:update-windows-deps

Conversation

@MisterDA
Copy link
Copy Markdown
Contributor

I've noticed that some of the dependencies could be updated. The updates could help when bootstrapping or building opam under Windows.

  • FlexDLL 0.44 (update from 0.43) brings fixes for linking with long filenames, linking under the multicore runtime, and fixes for cross-compilation. See the release notes and release announcement. FlexDLL 0.44 has already been published to the opam-repository and is used by all up-to-date switches on Windows.
  • msvs-detect 0.7.0 (update from 0.5.0) brings support for the latest Visual Studio, and various fixes. See release notes.
  • mingw-w64 13.0.0 (update from 12.0.0, CI only) has various improvements, but this shouldn't affect us too much (changelog).

I'm a bit dissatisfied to "dump" this PR on the maintainers this late in the release process, without being able to check if the CI follows through, but I don't have much more time available.

@kit-ty-kate
Copy link
Copy Markdown
Member

I'm a bit dissatisfied to "dump" this PR on the maintainers this late in the release process

I think it's ok as i don't think this should be part of the upcoming opam 2.4 which was branched already and whose release candidate has already been released. This PR will do fine for opam 2.5 though i think

@kit-ty-kate kit-ty-kate added this to the 2.5.0~alpha1 milestone Jul 10, 2025
@kit-ty-kate kit-ty-kate requested a review from dra27 October 7, 2025 16:17
@kit-ty-kate kit-ty-kate marked this pull request as ready for review October 13, 2025 12:15
@kit-ty-kate kit-ty-kate removed the request for review from dra27 October 13, 2025 22:22
@kit-ty-kate
Copy link
Copy Markdown
Member

Vendoring mingw-w64 13.0.0's winpthreads doesn't work with OCaml 5.3.0 because the source changed significantly. In particular the file that OCaml's configure script tried to lookup to detect whether winpthreads is here is now missing in that version.

I've removed that commit from the PR and it should now be good to go

@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit ea4f800 into ocaml:master Oct 14, 2025
55 of 79 checks passed
@MisterDA MisterDA deleted the update-windows-deps branch October 14, 2025 15:43
@kit-ty-kate
Copy link
Copy Markdown
Member

Turns out all of these dependencies simply do not work with OCaml 4.14 so i have to revert this PR. I'm not too sure why it works in CI but not during the release process though. We can revisit it once we upgrade to OCaml 5 (hopefully 5.5 or whenever the GC pacing issue is taken care of)

@MisterDA
Copy link
Copy Markdown
Contributor Author

Turns out all of these dependencies simply do not work with OCaml 4.14 so i have to revert this PR. I'm not too sure why it works in CI but not during the release process though.

Sorry, but that's simply wrong. The dependencies work well with OCaml 4.14. It's the bootstrap process that passes opam's version to FlexDLL instead of FlexDLL's version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants