Skip to content

--depext-only no longer return 0 if there is a conflict#6516

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
rjbou:depext-only-conflict
Oct 10, 2025
Merged

--depext-only no longer return 0 if there is a conflict#6516
kit-ty-kate merged 2 commits intoocaml:masterfrom
rjbou:depext-only-conflict

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented May 14, 2025

Fix #6488

@rjbou rjbou marked this pull request as ready for review May 14, 2025 16:40
@rjbou rjbou force-pushed the depext-only-conflict branch from eb78e48 to 0453535 Compare May 15, 2025 07:36
@kit-ty-kate kit-ty-kate added this to the 2.5.0~alpha1 milestone May 28, 2025
@rjbou rjbou force-pushed the depext-only-conflict branch from 0453535 to bbf6b61 Compare October 10, 2025 17:44
@kit-ty-kate
Copy link
Copy Markdown
Member

Looks good. Could you add a test for when the depext itself isn't available? (using OPAMVAR_os_family=dummy-success:: i think)

Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 76b46ac into ocaml:master Oct 10, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

depext installation failure results in error code 0

2 participants